Would Schindler consider himself to be a hero of the holocaust? Why or why not ?

I don't think he would. At the end of the movie Scindler berates himself for not doing more for his Jews.

Schindler saved the lives of 1,200 Jews during the Holocaust and most likely would have acknowledged that he was a hero. However, in the second last scene of movie, "Schindler's List," the audience can see that Schindler was not satisfied with the amount of money he had previously spent and wished he had invested it on Jews. But internally, he would know that he was a hero, but would have liked to been a 'bigger' one.

Hope this helps.